[compiler-rt] r355013 - Attempt to fix buildbot after r354972 [#1]. NFCI.

Alexey Lapshin via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 27 10:36:46 PST 2019


Author: avl
Date: Wed Feb 27 10:36:46 2019
New Revision: 355013

URL: http://llvm.org/viewvc/llvm-project?rev=355013&view=rev
Log:
    Attempt to fix buildbot after r354972 [#1]. NFCI.

Modified:
    compiler-rt/trunk/lib/sanitizer_common/symbolizer/sanitizer_symbolize.cc

Modified: compiler-rt/trunk/lib/sanitizer_common/symbolizer/sanitizer_symbolize.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/symbolizer/sanitizer_symbolize.cc?rev=355013&r1=355012&r2=355013&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/symbolizer/sanitizer_symbolize.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/symbolizer/sanitizer_symbolize.cc Wed Feb 27 10:36:46 2019
@@ -37,8 +37,10 @@ bool __sanitizer_symbolize_code(const ch
   {
     llvm::raw_string_ostream OS(Result);
     llvm::symbolize::DIPrinter Printer(OS);
+    // TODO: it is neccessary to set proper SectionIndex here.
+    // object::SectionedAddress::UndefSection works for only absolute addresses.
     auto ResOrErr =
-        getDefaultSymbolizer()->symbolizeInlinedCode(ModuleName, ModuleOffset);
+        getDefaultSymbolizer()->symbolizeInlinedCode(ModuleName, {ModuleOffset, object::SectionedAddress::UndefSection});
     Printer << (ResOrErr ? ResOrErr.get() : llvm::DIInliningInfo());
   }
   return __sanitizer::internal_snprintf(Buffer, MaxLength, "%s",
@@ -51,8 +53,10 @@ bool __sanitizer_symbolize_data(const ch
   {
     llvm::raw_string_ostream OS(Result);
     llvm::symbolize::DIPrinter Printer(OS);
+    // TODO: it is neccessary to set proper SectionIndex here.
+    // object::SectionedAddress::UndefSection works for only absolute addresses.
     auto ResOrErr =
-        getDefaultSymbolizer()->symbolizeData(ModuleName, ModuleOffset);
+        getDefaultSymbolizer()->symbolizeData(ModuleName, {ModuleOffset, object::SectionedAddress::UndefSection});
     Printer << (ResOrErr ? ResOrErr.get() : llvm::DIGlobal());
   }
   return __sanitizer::internal_snprintf(Buffer, MaxLength, "%s",




More information about the llvm-commits mailing list