[PATCH] D58677: [llvm-readobj]Add additional testing for various ELF features
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 27 08:35:06 PST 2019
jhenderson added inline comments.
================
Comment at: test/tools/llvm-readobj/elf-dynamic-tags.test:150
+ Content: "004400550066007700"
+ - Name: .dynamic
+ Type: SHT_DYNAMIC
----------------
Higuoxing wrote:
> I think here should be linked with .dynstr
> ```
> - Name: .dynamic
> Link: 1
> ```
> Or, objdump cannot dump this. But, never mind here :)
I'm trying to keep these tests as minimal as possible, because there's already a lot of stuff in it. llvm-readobj does not require the link field, because it uses the dynamic tags.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58677/new/
https://reviews.llvm.org/D58677
More information about the llvm-commits
mailing list