[PATCH] D58677: [llvm-readobj]Add additional testing for various ELF features

[James Henderson via Phabricator via llvm-commits]

jhenderson updated this revision to Diff 188540.
jhenderson marked 10 inline comments as done.
jhenderson added a comment.

Address review comments:

1. Rename tests to lower case.
2. Fix test file names.
3. Change tags in reserved range to be more sensible.
4. Use all values in DT_FLAGS and DT_FLAGS_1 tags.
5. Add a couple of comments for clarity.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58677/new/

https://reviews.llvm.org/D58677

Files:
  test/tools/llvm-readobj/elf-dynamic-empty.test
  test/tools/llvm-readobj/elf-dynamic-malformed.test
  test/tools/llvm-readobj/elf-dynamic-no-pt-dynamic.test
  test/tools/llvm-readobj/elf-dynamic-tags-machine-specific.test
  test/tools/llvm-readobj/elf-dynamic-tags.test
  test/tools/llvm-readobj/elf-malformed-pt-dynamic.test
  test/tools/llvm-readobj/elf-no-phdrs.test
  test/tools/llvm-readobj/elf-no-relocs.test
  test/tools/llvm-readobj/elf-no-shdrs.test
  test/tools/llvm-readobj/elf-types.test
  test/tools/llvm-readobj/string-dump.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58677.188540.patch
Type: text/x-patch
Size: 45060 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190227/a642bd22/attachment.bin>