[PATCH] D58707: [llvm-objdump] Should print strings when dumping DT_RPATH, DT_RUNPATH, DT_SONAME, DT_AUXILIARY and DT_FILTER tags in dynamic section.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D58707#1411859 <https://reviews.llvm.org/D58707#1411859>, @Higuoxing wrote:

> Thanks for the test file, I noticed that the last 5 d_tag are unknown. We should print them in hex format. I would like to resolve it in another 
>  patch.


Sounds reasonable. You may notice from the comments in D58677 <https://reviews.llvm.org/D58677> that I'm going to make a couple of changes to that file in the "unknown" region. Perhaps you should just miss them out for now, and do them later when you fix the behaviour? Basically, we just want to show that the values in that range are printed sensibly.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58707/new/

https://reviews.llvm.org/D58707