[PATCH] D58677: [llvm-readobj]Add additional testing for various ELF features

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/tools/llvm-readobj/elf-dynamic-malformed.test:92
+      - Tag:   DT_NEEDED
+        Value: 1
+      - Tag:   DT_NULL
----------------
Do I correctly understand that issue here is that DT_NEEDED has a value 0x1, which
is an offset in a .dynstr, and the issue is that DT_STRSZ says that .dynstr has a total size of 1
(and so offset 0x1 is past the end of the section)?

If so, it is not really obvious perhaps, I would suggest extending the comment for this sub-test.


================
Comment at: test/tools/llvm-readobj/elf-dynamic-tags.test:275
+      - Tag:   0x7ffffffe
+        Value: 0x8888777766665555
+      - Tag:   DT_NULL
----------------
Could you explain the logic of numeric tags for me?

I see you're testing LOPROC and (HIPROC-1) it seems:

> DYNAMIC_TAG_MARKER(LOOS, 0x60000000)   // Start of environment specific tags.
> DYNAMIC_TAG_MARKER(HIOS, 0x6FFFFFFF)   // End of environment specific tags.
> DYNAMIC_TAG_MARKER(LOPROC, 0x70000000) // Start of processor specific tags.
> DYNAMIC_TAG_MARKER(HIPROC, 0x7FFFFFFF) // End of processor specific tags.

But what is 0x6000000D and 0x6ffff000 then?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58677/new/

https://reviews.llvm.org/D58677