[PATCH] D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: compiler-rt/lib/crt/crtbegin.c:17
+#else
+void *__dso_handle = (void *)0;
+#endif
----------------
Should there be a `#ifdef` macro to exclude `__dso_handle`? glibc libc.a also provides `__dso_handle`.


================
Comment at: compiler-rt/lib/crt/crtbegin.c:21
+static long __EH_FRAME_LIST__[] __attribute__((
+    section(".eh_frame"), aligned(sizeof(void *)), visibility("hidden"))) = {};
+
----------------
Remove `, visibility("hidden")`

The visibility attribute is ignored for static variables and GCC would emit a `-Wattributes` warning.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D28791/new/

https://reviews.llvm.org/D28791