[PATCH] D58707: [llvm-objdump] Should print strings when dumping DT_RPATH and DT_RUNPATH tags in dynamic section.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 27 01:39:48 PST 2019


grimar added a comment.

> Only a small problem here, I have no idea on choosing test case. I see there's a test 
>  file(test/tools/llvm-objdump/private-headers-dynamic-section.test). But it has no DT_RPATH and DT_RUNPATH tags. Shall I replace the ELF file in the 
>  Inputs dir by a new one?

Looking at that test, I think now we should be able to convert it to use yaml2obj instead of using the precompiled binary (as an independent change).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58707/new/

https://reviews.llvm.org/D58707





More information about the llvm-commits mailing list