[PATCH] D58102: Support X86 Control-flow Enforcement Technology (CET) in LLD

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added a comment.



> This will not work because it makes it impossible to roll out CET support in a distribution incrementally. Each time a library is CET-enabled (because all its assembler files are properly annotated), all reverse dependencies would have to be patched and their build systems changed to pass a new flag to the linker.
> 
> How does lld handle the non-executable stack flag? From a developer point of view, the CET processing is supposed to be very similar.

Yes the CET can't be mandatory now, and we will re-writing the OS kernels and libs to support it, anyway there will be a very long way to go.
So, now CET in this patch is very easy to be disabled (once linked any non-CET input file). It won't infect current non-CET programs.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58102/new/

https://reviews.llvm.org/D58102