[PATCH] D58552: [compiler-rt] Windows Trace Logging for error reports.

[Matthew G McGovern via Phabricator via llvm-commits]

mcgov marked 3 inline comments as done.
mcgov added a comment.

Fixed concurrency issue from global provider access. Addressed comments from @vitalybuka



================
Comment at: lib/sanitizer_common/sanitizer_win.cc:1078
+    internal_memset(Filename, 0, MAX_PATH + 1);
+    GetModuleFileNameA(NULL, Filename, MAX_PATH);
+    HRESULT hr = TraceLoggingRegister(g_hAsanProvider);
----------------
vitalybuka wrote:
> also why MAX_PATH and why non unicode version?
> also GetModuleFileNameA may truncate the string
> Better to use the size returned from GetModuleFileName
> and dynamically allocated with InternalScopedString or InternalMmapVector(for unicode)
Good note! Thank you, I've rewritten it to use a vector and wchar_t.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58552/new/

https://reviews.llvm.org/D58552