[PATCH] D58651: [NFC][Sanitizer] Pull up GetStackTrace into sanitizer_common
Julian Lettner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 26 14:34:23 PST 2019
yln marked 2 inline comments as done.
yln added inline comments.
================
Comment at: compiler-rt/lib/tsan/rtl/tsan_stack_trace.cc:57
+ uptr bottom = 0;
+ bool fast = common_flags()->fast_unwind_on_fatal;
+ if (StackTrace::WillUseFastUnwind(fast)) {
----------------
vitalybuka wrote:
> why common_flags()->fast_unwind_on_fatal when you had argument request_fast_unwind?
Good catch! Thank you for your diligent reviews! :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58651/new/
https://reviews.llvm.org/D58651
More information about the llvm-commits
mailing list