[PATCH] D58651: [NFC][Sanitizer] Pull up GetStackTrace into sanitizer_common
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 26 14:14:39 PST 2019
vitalybuka added a comment.
I like it!
================
Comment at: compiler-rt/lib/tsan/rtl/tsan_stack_trace.cc:57
+ uptr bottom = 0;
+ bool fast = common_flags()->fast_unwind_on_fatal;
+ if (StackTrace::WillUseFastUnwind(fast)) {
----------------
why common_flags()->fast_unwind_on_fatal when you had argument request_fast_unwind?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58651/new/
https://reviews.llvm.org/D58651
More information about the llvm-commits
mailing list