[PATCH] D57541: [DAGCombiner] Eliminate dead stores to stack.

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 26 13:28:38 PST 2019


niravd added inline comments.


================
Comment at: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:15524
+        Chains.push_back(Chain.getOperand(0));
+      }
+      break;
----------------
Ahha! We never add the lifetime to the Alias list like we should if we dont' skip past it. I suspect this is why we had to revert this patch.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57541/new/

https://reviews.llvm.org/D57541





More information about the llvm-commits mailing list