[PATCH] D58670: [LLD][ELF] - Improve "sh_addralign is not a power of 2" diagnostics.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 26 11:09:13 PST 2019


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/InputSection.cpp:79
   if (!isPowerOf2_64(V))
-    fatal(toString(File) + ": section sh_addralign is not a power of 2");
+    fatal(toString(this) + ": section sh_addralign is not a power of 2");
   this->Alignment = V;
----------------
I think " section" is now redundant and should be removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58670/new/

https://reviews.llvm.org/D58670





More information about the llvm-commits mailing list