[PATCH] D58669: [ELF] Explain some options in ld.lld.1

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Thank you for doing this.



================
Comment at: docs/ld.lld.1:221
+.It Fl -ignore-data-address-equality
+Ignore address equality of data. This options allows copy relocation for object
+symbols with non-default visibility. When used together with
----------------
options -> option


================
Comment at: docs/ld.lld.1:222-224
+symbols with non-default visibility. When used together with
+.Fl -icf=all ,
+both .dynsym and .llvm_addrsig are ignored for ICF.
----------------
I'd think this is hard to understand for those who are just reading this manual page. We don't explain anything about .llvm_addrsig for example.

Maybe it's better to explain it at a high level first? For example: C/C++ requires each data has a unique address. This option allows lld do unsafe optimization that breaks the requirement. If this option is given, lld may create copies of read-only data or merge two or more read-only data that happen to have the same value.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58669/new/

https://reviews.llvm.org/D58669