[PATCH] D58055: [CMake][LibFuzzer] Match symbol visibility setting between LibFuzzer object files and unit tests.

[Julian Lettner via Phabricator via llvm-commits]

yln added a comment.

LGTM. Compiling all linker inputs with the same visibility is the right approach.

Please check my understanding:
Before r336238 the `kIgnoreRemaining` constant got inlined, both into libFuzzer and the unit test. So we had two definitions, one with hidden and one with default visibility resulting in a linker warning. If we (just for testing purposes) compile libFuzzer without hidden visibility, we would get a "duplicate symbol" linker error. With this patch we have two hidden definitions, which is fine.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58055/new/

https://reviews.llvm.org/D58055