[PATCH] D58552: [compiler-rt] Windows Trace Logging for error reports.

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

LGTM



================
Comment at: lib/sanitizer_common/sanitizer_win.cc:36
+#pragma comment(lib, "advapi32.lib")
+// advapi32 needed for win10 tracelogging.
 
----------------
usually comment goes same line or above


================
Comment at: lib/sanitizer_common/sanitizer_win.cc:1076
+  if (common_flags()->log_to_syslog){
+    char Filename[MAX_PATH + 1] = {0};
+    GetModuleFileNameA(NULL, Filename, MAX_PATH);
----------------
```
=  {};
```

but maybe better to use internal_memcpy to avoid memcpy interceptors


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58552/new/

https://reviews.llvm.org/D58552