[PATCH] D53379: GSYM symbolication format

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added inline comments.


================
Comment at: include/llvm/DebugInfo/GSYM/GsymCreator.h:74
+    std::lock_guard<std::mutex> Guard(Mutex);
+    std::sort(Funcs.begin(), Funcs.end());
+  }
----------------
Please use range based llvm::sort instead of std::sort.
```
llvm::sort(Funcs);
```

See https://llvm.org/docs/CodingStandards.html#beware-of-non-deterministic-sorting-order-of-equal-elements for more details.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53379/new/

https://reviews.llvm.org/D53379