[PATCH] D58615: [llvm-objdump] Add `Version Definitions` dumper

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with one nit still.



================
Comment at: tools/llvm-objdump/ELFDump.cpp:312
+  uint32_t VerdefIndex = 1;
+  // sh_info contains the number of entries of verdef section.
+  // To make the index column have consistent width, we should
----------------
jhenderson wrote:
> "entries of verdef section" -> "entries in the SHT_GNU_verdef" section. You have also manually formatted the paragraph, with line breaks that are too early, rather than letting clang-format do it for you.
"entries of" -> "entries in the"

(like I already requested...)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58615/new/

https://reviews.llvm.org/D58615