[PATCH] D58667: [yaml2obj][obj2yaml] - Add support for the architecture specific dynamic tags.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

It's like you read my mind. I'm literally in the middle of writing an llvm-readobj test for dynamic tag dumping!



================
Comment at: test/tools/obj2yaml/dynamic-section-arch-tags.test:112-113
+    Type:            SHT_DYNAMIC
+    Address:         0x0000000000001000
+    AddressAlign:    0x0000000000002000
+    Entries:
----------------
I don't think you need Address or AddressAlign in this test.


================
Comment at: test/tools/obj2yaml/dynamic-section-arch-tags.test:115-116
+    Entries:
+      - Tag:             DT_NULL
+        Value:           0x0000000000000000
+      - Tag:             DT_MIPS_RLD_VERSION
----------------
I don't think you need the DT_NULL tags either?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58667/new/

https://reviews.llvm.org/D58667