[PATCH] D58626: [DAG] Fix constant store folding to handle non-byte sizes.

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added a comment.

Added a few nits about too long lines.



================
Comment at: llvm/include/llvm/CodeGen/SelectionDAGAddressAnalysis.h:65
   // contained in `*this` (with size `Size`).
-  bool contains(int64_t Size, const BaseIndexOffset &Other, int64_t OtherSize,
-                const SelectionDAG &DAG) const {
-    int64_t Offset;
-    return contains(Size, Other, OtherSize, DAG, Offset);
-  }
+  bool contains(const SelectionDAG &DAG, int64_t BitSize, const BaseIndexOffset &Other, int64_t OtherBitSize,
+                int64_t &BitOffset) const;
----------------
long line


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAGAddressAnalysis.h:69
 
-  bool contains(int64_t Size, const BaseIndexOffset &Other, int64_t OtherSize,
-                const SelectionDAG &DAG, int64_t &Offset) const;
+  bool contains(const SelectionDAG &DAG, int64_t BitSize, const BaseIndexOffset &Other, int64_t OtherBitSize) const {
+    int64_t BitOff;
----------------
long line


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGAddressAnalysis.cpp:139
+
+bool BaseIndexOffset::contains(const SelectionDAG &DAG, int64_t BitSize, const BaseIndexOffset &Other,
+                               int64_t OtherBitSize, int64_t &BitOffset) const {
----------------
long line


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58626/new/

https://reviews.llvm.org/D58626