[PATCH] D57600: update docs of memcpy/memmove/memset re: alignment and len=0
Ralf via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 26 01:45:52 PST 2019
RalfJung added a comment.
> Please make sure you have llvm-commits added as a subscriber when creating patches in the future
Thanks, I'll try to remember. It might be worth clarifying at https://llvm.org/docs/Phabricator.html#phabricator-request-review-web that "adding a reviewer" and "subscribing someone" is *not* the same thing. As someone who has not used Phabricator ever before, I figured these would just be different terms for the same thing; I had no idea there are separate lists of "reviewers" and "subscribers" (llvm-commits is, after all, mentioned in the bullet point that is all about adding reviewers).
> was meaning to update the docs but never did
Notice that this does not just fix the fallout from that patch. The remarks about what happens when "len" is 0 are new, and based on the feedback I received at https://bugs.llvm.org/show_bug.cgi?id=38583.
I also just found a typo in my patch, so now I will have to figure out how to update a patch here.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57600/new/
https://reviews.llvm.org/D57600
More information about the llvm-commits
mailing list