[PATCH] D58626: [DAG] Fix constant store folding to handle non-byte sizes.

[Clement Courbet via Phabricator via llvm-commits]

courbet accepted this revision.
courbet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAGAddressAnalysis.h:63
 
   // Returns true if `Other` (with size `OtherSize`) can be proven to be fully
   // contained in `*this` (with size `Size`).
----------------
please update the comment.


================
Comment at: llvm/include/llvm/CodeGen/SelectionDAGAddressAnalysis.h:70
+  bool contains(const SelectionDAG &DAG, int64_t BitSize, const BaseIndexOffset &Other, int64_t OtherBitSize) const {
+    int64_t BitOff;
+    return contains(DAG, BitSize, Other, OtherBitSize, BitOff);
----------------
`BitOffset` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58626/new/

https://reviews.llvm.org/D58626