[PATCH] D58632: [X86] Improve lowering of idemptotent RMW operations

[Philip Reames via Phabricator via llvm-commits]

reames planned changes to this revision.
reames marked 2 inline comments as done.
reames added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:25482
   // rmw. In practice, they do not look useful, so we don't try to be
   // especially clever.
   if (SSID == SyncScope::SingleThread)
----------------
jfb wrote:
> This comment needs an update.
I'm not sure what update you're asking for.  If we fall down this path, the comments appear correct as they ever were.  Something I'm missing?


================
Comment at: test/CodeGen/X86/atomic-idempotent.ll:193
+  ret void
+}
+
----------------
jfb wrote:
> Can you test `monotonic` as well?
> Also, `i8` and `i16`.
Will do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58632/new/

https://reviews.llvm.org/D58632