[PATCH] D58562: [WebAssembly] Improve readability of EH tests

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: test/CodeGen/WebAssembly/cfg-stackify-eh.ll:94
 ; CHECK-LABEL: test1
-; CHECK:   try
-; CHECK:   call      foo
-; CHECK:   catch
-; CHECK:   br_on_exn 0, __cpp_exception
-; CHECK:   rethrow
-; CHECK:   i32.call  $drop=, _Unwind_CallPersonality
-; CHECK:   try
-; CHECK:   call      foo
-; CHECK:   catch
-; CHECK:   br_on_exn   0, __cpp_exception
-; CHECK:   rethrow
-; CHECK:   i32.call  $drop=, _Unwind_CallPersonality
-; CHECK:   try
-; CHECK:   i32.call  $drop=, __cxa_begin_catch
-; CHECK:   try
-; CHECK:   call      foo
-; CHECK:   catch     $drop=
-; CHECK:   rethrow
-; CHECK:   end_try
-; CHECK:   catch     $drop=
-; CHECK:   rethrow
-; CHECK:   end_try
-; CHECK:   end_try
-; CHECK:   end_try
-; CHECK:   return
+; TODO Fill in check lines
 define void @test1() personality i8* bitcast (i32 (...)* @__gxx_wasm_personality_v0 to i8*) {
----------------
dschuff wrote:
> Could you be more specific here? e.g. "fill in the check lines when we are able to compile this" or "when XXX condition is met"
Done. And it's gonna be filled in in D58605. (With that bug, the indentation cannot be done here because that bug creates incorrect structures like
```
try
  block
catch
  end_block
end_try
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58562/new/

https://reviews.llvm.org/D58562