[PATCH] D58599: [LLD] Add summary support

[Alexandre Ganea via Phabricator via llvm-commits]

aganea marked 2 inline comments as done.
aganea added a comment.

In D58599#1409821 <https://reviews.llvm.org/D58599#1409821>, @ruiu wrote:

> Could you elaborate a bit about why you want this feature?
>
> Instead of adding a flag, you might want to do that when /verbose is given.


Essentially to have a better understanding of where the timings go. With many different clients and many different usages, seeing the `/time` values does not tell me what caused those timings. `/summary` gives me more hints on the "what" and also allows compares between different usages. This is primarily geared towards the PDB generation, because that's what takes the most time, and because that's where I'd like to put the most efforts on.

In contrast, `/verbose` is more for the day-to-day users of the linker. For example if you want to understand wrong lib paths, or missing symbols.
I suppose I could print the information I want for summary at the end of `/verbose` output, however that forces to wait on the excruciatingly long `/verbose` console output. Output which cannot be redirected by the way, for a reason I haven't investigated yet.
The following __does not__ produce the expected result - instead the text is printed on the console, and the dump file is empty:

  lld-link.exe ... /verbose >dump.txt



================
Comment at: COFF/PDB.cpp:1361
   }
 }
 
----------------
ruiu wrote:
> Looks like instead of pushing stats data to a `Summary` class and print it out later, you could print out the stats right here.
That would skew profiles recorded for `/time`. I often use `/time` and  `/summary` at the same time.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58599/new/

https://reviews.llvm.org/D58599