[PATCH] D58589: [ConstantHoisting] Call releaseMemory() to avoid dangling elements in ConstIntInfoVec

Mon Feb 25 18:23:31 PST 2019

MaskRay marked 3 inline comments as done.
MaskRay added inline comments.

================
Comment at: lib/Transforms/Scalar/ConstantHoisting.cpp:950

+  releaseMemory();
+
----------------
ormris wrote:
> ormris wrote:
> > If this only happens in the new pass manager, could this call be moved to ::run? That way, the legacy pass manager doesn't call this function twice.
> s/::run/ConstantHoistingPass::run/g
Thanks! I think maybe it makes more sense to delete releaseMemory() and inline it into the end of runImpl. I've updated the patch to do that.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58589/new/

https://reviews.llvm.org/D58589