[PATCH] D58661: [llvm-cov] Fix llvm-cov on Windows and un-XFAIL test

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

In D58661#1410041 <https://reviews.llvm.org/D58661#1410041>, @vsk wrote:

> I suppose Names{Start,End} are needed on Windows so that we can find section boundaries.


Yep. Along the way I tried this creative code pattern, which works with clang but not MSVC:

  const char COMPILER_RT_SECTION(".lprfn$A") NamesStart[0] = {};
  const char COMPILER_RT_SECTION(".lprfn$Z") NamesEnd[0] = {};



> Thanks, lgtm.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58661/new/

https://reviews.llvm.org/D58661