[PATCH] D58535: [OptRemarks] Make OptRemarks more generic: rename OptRemarks to Remarks

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg marked an inline comment as done.
thegameg added inline comments.


================
Comment at: llvm/unittests/Remarks/RemarksParsingTest.cpp:278
+      "expected a value of scalar type."));
+  // Not a integer line in debug loc.
+  EXPECT_TRUE(parseExpectError(
----------------
thegameg wrote:
> paquette wrote:
> > What happens if you give a negative line or column number?
> For now, we get:
> 
> ```
> YAML:4:46: error: expected a value of integer type.
> 
> DebugLoc:        { File: test_parse.c, Line: -12, Column: 12 }
>                                              ^~~
> ```
> 
> Which is pretty bad. I will update the parser in a future patch.
(btw, the contents of this test didn't change, Phabricator just doesn't know that it was llvm/lib/OptRemarks/OptRemarksParser.cpp before)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58535/new/

https://reviews.llvm.org/D58535