[PATCH] D58535: [OptRemarks] Make OptRemarks more generic: rename OptRemarks to Remarks

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 25 16:10:46 PST 2019


thegameg updated this revision to Diff 188268.
thegameg marked 10 inline comments as done.
thegameg edited the summary of this revision.
thegameg added a comment.

I decided to change the goal for this patch a little:

- Keep "optimization remarks" in the remark generation code. This makes more sense because it is specific to remarks for optimizations.
- Only rename it in the parser/library code. This part of the code is going to be used on the client side (llvm-opt-report, opt-viewer, etc.), and this is the main part that we're looking to share for all the types of remarks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58535/new/

https://reviews.llvm.org/D58535

Files:
  llvm/cmake/modules/AddLLVM.cmake
  llvm/include/llvm-c/OptRemarks.h
  llvm/include/llvm-c/Remarks.h
  llvm/lib/CMakeLists.txt
  llvm/lib/LLVMBuild.txt
  llvm/lib/OptRemarks/CMakeLists.txt
  llvm/lib/OptRemarks/LLVMBuild.txt
  llvm/lib/OptRemarks/OptRemarksParser.cpp
  llvm/lib/Remarks/CMakeLists.txt
  llvm/lib/Remarks/LLVMBuild.txt
  llvm/lib/Remarks/RemarkParser.cpp
  llvm/tools/llvm-opt-report/CMakeLists.txt
  llvm/tools/llvm-opt-report/OptReport.cpp
  llvm/tools/opt-remarks/CMakeLists.txt
  llvm/tools/opt-remarks/OptRemarks.exports
  llvm/tools/opt-remarks/liboptremarks.cpp
  llvm/tools/remarks-shlib/CMakeLists.txt
  llvm/tools/remarks-shlib/Remarks.exports
  llvm/tools/remarks-shlib/libremarks.cpp
  llvm/unittests/CMakeLists.txt
  llvm/unittests/OptRemarks/CMakeLists.txt
  llvm/unittests/Remarks/CMakeLists.txt
  llvm/unittests/Remarks/RemarksParsingTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58535.188268.patch
Type: text/x-patch
Size: 42146 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190226/be6d6a42/attachment.bin>


More information about the llvm-commits mailing list