[PATCH] D58585: [DAGCombine] Add undef shuffle elt support to partitionShuffleOfConcats

[Mark Lacey via Phabricator via llvm-commits]

rudkx added inline comments.


================
Comment at: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:17407
+        continue;
+      if ((SubMask[i] % NumElemsPerConcat) != i)
         return SDValue();
----------------
This results in a new build warning:

```
../lib/CodeGen/SelectionDAG/DAGCombiner.cpp:17407:44: warning: comparison of integers of different signs: 'unsigned int' and 'int' [-Wsign-compare]
      if ((SubMask[i] % NumElemsPerConcat) != i)
```

Would you mind taking a look at fixing that?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58585/new/

https://reviews.llvm.org/D58585