[PATCH] D58598: [CMake] Support alternative C++ ABI library

Mon Feb 25 14:14:07 PST 2019

phosek marked an inline comment as done.
phosek added inline comments.

================
Comment at: CMakeLists.txt:162
+set(CXXABIS none default libstdc++ libsupc++ libc++ libc++abi)
+set_property(CACHE TEST_SUITE_CXX_ABI PROPERTY STRINGS ;${CXXABIS})
+if (TEST_SUITE_CXX_ABI STREQUAL "default")
----------------
phosek wrote:
> smeenai wrote:
> > phosek wrote:
> > > smeenai wrote:
> > > > What's the purpose of the leading semicolon?
> > > TBH I don't really know, this is being used in compiler-rt CMake. AFAIK this is only needed for CMake GUI which I don't have any experience with, I'm fine omitting it.
> > I would think it's allowing an empty string as one of the values, but I'm not sure why you'd want that? It's a GUI-only thing though and CMake doesn't enforce it, so I don't think it matters either way.
> It should work for us, we ship c++abi on Fuchsia, we don't ship c++abi in our Linux host runtime, but for that one I'll have to use `TEST_SUITE_CXX_ABI` in any case.
More generally, I'm fine going with this, and re-evaluate it if it turns out we need c++.

Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58598/new/

https://reviews.llvm.org/D58598