[PATCH] D58643: [Support] Make raw_string_ostream unbuffered

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 25 13:37:50 PST 2019


rnk added a comment.

In D58643#1409707 <https://reviews.llvm.org/D58643#1409707>, @lebedev.ri wrote:

> Uhm, but if we disable buffering, and cripple `flush()`, shouldn't we also make it impossible to turn the buffering back on?
>  Existing test fails with this change, and if i add similar test with `SmallString`/`raw_svector_ostream` it also fails in trunk.


Can work around this by calling `this->raw_ostream::flush()` from `str()` and `~raw_string_ostream`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58643/new/

https://reviews.llvm.org/D58643





More information about the llvm-commits mailing list