[PATCH] D58621: [XRay][tools] Pack XRayRecord - reduce memory footprint by a third. (RFC)

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added a comment.

> This is a RFC because of the uint8_t CPU change.
>  That chance needs discussing.

So, this is an accident of history, which should be changed, but to the other direction. I've learned some time ago that it turns out there are some platforms that can have enough CPU IDs which can't be represented by a uint8_t. For future-proofing, we really should change this to be larger (`uint16_t`) and change basic mode to store 16-bit CPU IDs. The other parts seem fine to me, except for the potential churn on the user side (this is an ABI change).

I //think// that's fine for the C++ APIs, but that it will need some release notes (in case someone has been using the `Trace` API).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58621/new/

https://reviews.llvm.org/D58621