[PATCH] D58643: [Support] Make raw_string_ostream unbuffered
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 25 12:48:13 PST 2019
lebedev.ri marked an inline comment as done.
lebedev.ri added a comment.
In D58643#1409649 <https://reviews.llvm.org/D58643#1409649>, @rnk wrote:
> lgtm
Thank you for the review.
> Leaving flush alone is fine.
The problem being that i still haven't migrated to the monorepo.
Hm, actually, i think i can do it (well, except lldb), simply by doing all the changes,
committing them, and then committing the removal of the method itself last.
I'll look into that later.
================
Comment at: include/llvm/Support/raw_ostream.h:497
+ explicit raw_string_ostream(std::string &O)
+ : raw_ostream(/*Unbuffered=*/true), OS(O) {}
+
----------------
rnk wrote:
> Huh, I suppose that is nicer than calling SetUnbuffered.
Thanks
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58643/new/
https://reviews.llvm.org/D58643
More information about the llvm-commits
mailing list