[PATCH] D58598: [CMake] Support alternative C++ ABI library

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: CMakeLists.txt:165
+  if (APPLE OR CMAKE_SYSTEM_NAME MATCHES "FreeBSD|Fuchsia")
+    set(TEST_SUITE_CXX_ABI_LIBNAME "c++")
+  else()
----------------
smeenai wrote:
> phosek wrote:
> > smeenai wrote:
> > > Why c++ instead of c++abi?
> > Not every platform ships separate C++ ABI library, e.g. in our toolchain we combine libc++abi and libc++ into a single library.
> Fair enough. Last I checked you'd run into issues if libc++ and libc++abi were separate static libraries, since you wouldn't get the linker script that links libc++abi as well as libc++ in that case, but I don't think many people use that setup.
Sorry if I was unclear ... I was okay with this one being c++ for the reasons you stated (although the inconsistency with supc++ would be a bit strange). Is this still going to work for you, given you don't ship c++abi?


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58598/new/

https://reviews.llvm.org/D58598