[PATCH] D58580: [Support] llvm::to_string(): raw_string_ostream is a memory hog

[Reid Kleckner via Phabricator via llvm-commits]

rnk requested changes to this revision.
rnk added a comment.
This revision now requires changes to proceed.

`operator<<` does this internally, see `write_unsigned_impl`. Instead of doing this, let's just disable buffering in raw_string_ostream. We already do it in raw_svector_ostream.

Also, how did llvm::to_string end up being so popular. We should move it to STLExtras.h from ScopedPrinter.h, or discourage its use in general.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58580/new/

https://reviews.llvm.org/D58580