[PATCH] D58614: Fixed a typo in the test s/CEHCK/CHECK/

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 25 07:29:25 PST 2019


lebedev.ri added a comment.

In D58614#1408924 <https://reviews.llvm.org/D58614#1408924>, @jsji wrote:

> LGTM. Thanks for catching this, I am surprised that those typos slipped through ... FYI. @HLJ2009


Two things here.

1. Why is `CHECK-NEXT` not being used?
2. Why is `./utils/update_llc_test_checks.py` not being used? That dramatically reduces chances of things like this, and spares one from actually having to manually write proper check lines. (thus improves test coverage. one will of course still need to verify that the checks are correct.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58614/new/

https://reviews.llvm.org/D58614





More information about the llvm-commits mailing list