[PATCH] D58615: [llvm-objdump] Add `Version Definitions` dumper

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

This LGTM. A minor suggestion is inline. 
Please wait for @jhenderson	opinion too.



================
Comment at: tools/llvm-objdump/ELFDump.cpp:310
+  const uint8_t *Buf = Contents.data();
+  uint32_t VerdefIndex = 0;
+  while (Buf) {
----------------
You can start from 1:

`VerdefIndex = 1;`


================
Comment at: tools/llvm-objdump/ELFDump.cpp:313
+    const Elf_Verdef *Verdef = reinterpret_cast<const Elf_Verdef *>(Buf);
+    outs() << VerdefIndex + 1 << " "
+           << format("0x%02" PRIx16 " ", (uint16_t)Verdef->vd_flags)
----------------
And do:

```
outs() << VerdefIndex++ << " "
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58615/new/

https://reviews.llvm.org/D58615