[PATCH] D57321: Fix LexFloatLiteral Lexing

Brandon Jones via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 25 03:22:10 PST 2019


BrandonTJones marked 5 inline comments as done.
BrandonTJones added inline comments.


================
Comment at: llvm/lib/MC/MCParser/AsmLexer.cpp:153
+    if (!IsIdentifierChar(*CurPtr, AllowAtInIdentifier) ||
+        *CurPtr == 'e' || *CurPtr == 'E')
       return LexFloatLiteral();
----------------
efriedma wrote:
> This change doesn't do anything?
This change arised from a merge conflict in my local repo, the new diff is more in keeping with the order from before the patch originally which is why I have kept it


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57321/new/

https://reviews.llvm.org/D57321





More information about the llvm-commits mailing list