[PATCH] D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 marked an inline comment as done.
evgeny777 added inline comments.


================
Comment at: tools/llvm-objcopy/CopyConfig.cpp:572
+      auto Expr = Config.EntryExpr ? std::move(Config.EntryExpr)
+                                   : [](uint64_t A) { return A; };
+      Config.EntryExpr = [Expr, EIncr](uint64_t EAddr) {
----------------
jhenderson wrote:
> Could you just make this the default? I.e. set Config.EntryExpr to return the input unless something overrides it?
How to deal with COFF variant? Setting this option should be an error in such case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58173/new/

https://reviews.llvm.org/D58173