[PATCH] D58490: [ARM, Lanai] Be super conservative about atomics

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 25 01:57:43 PST 2019


chill added inline comments.


================
Comment at: lib/Target/ARM/ARMLoadStoreOptimizer.cpp:1584
+  // TODO: Unclear whether we need to be as defense about atomic operations.
+  if (MMO.isVolatile() || MMO.isAtomic())
     return false;
----------------
How about using `MachineMemOperand::isUnordered()` instead?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58490/new/

https://reviews.llvm.org/D58490





More information about the llvm-commits mailing list