[PATCH] D58598: [CMake] Support alternative C++ ABI library

[Petr Hosek via Phabricator via llvm-commits]

phosek marked 3 inline comments as done.
phosek added inline comments.


================
Comment at: CMakeLists.txt:162
+set(CXXABIS none default libstdc++ libsupc++ libc++ libc++abi)
+set_property(CACHE TEST_SUITE_CXX_ABI PROPERTY STRINGS ;${CXXABIS})
+if (TEST_SUITE_CXX_ABI STREQUAL "default")
----------------
smeenai wrote:
> What's the purpose of the leading semicolon?
TBH I don't really know, this is being used in compiler-rt CMake. AFAIK this is only needed for CMake GUI which I don't have any experience with, I'm fine omitting it.


================
Comment at: CMakeLists.txt:165
+  if (APPLE OR CMAKE_SYSTEM_NAME MATCHES "FreeBSD|Fuchsia")
+    set(TEST_SUITE_CXX_ABI_LIBNAME "c++")
+  else()
----------------
smeenai wrote:
> Why c++ instead of c++abi?
Not every platform ships separate C++ ABI library, e.g. in our toolchain we combine libc++abi and libc++ into a single library.


================
Comment at: CMakeLists.txt:167
+  else()
+    set(TEST_SUITE_CXX_ABI_LIBNAME "stdc++")
+  endif()
----------------
smeenai wrote:
> Why stdc++ instead of supc++?
The same as above, I'm fine keeping it as supc++ to match the current behavior, although stdc++ seems safer to me.


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58598/new/

https://reviews.llvm.org/D58598