[PATCH] D58597: [X86] Merge ISD::ADD/SUB nodes into X86ISD::ADD/SUB equivalents (PR40483)

[Craig Topper via Phabricator via llvm-commits]

craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM with one minor



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:41001
+    if (SDNode *GenericAddSub = DAG.getNodeIfExists(GenericOpc, VTs, Ops)) {
+      SDValue Res(N, 0);
+      DCI.CombineTo(GenericAddSub, Res);
----------------
Why not just pass SDValue(N, 0) in the CombineTo call?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58597/new/

https://reviews.llvm.org/D58597