[PATCH] D58598: [CMake] Support alternative C++ ABI library

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added inline comments.


================
Comment at: CMakeLists.txt:162
+set(CXXABIS none default libstdc++ libsupc++ libc++ libc++abi)
+set_property(CACHE TEST_SUITE_CXX_ABI PROPERTY STRINGS ;${CXXABIS})
+if (TEST_SUITE_CXX_ABI STREQUAL "default")
----------------
What's the purpose of the leading semicolon?


================
Comment at: CMakeLists.txt:165
+  if (APPLE OR CMAKE_SYSTEM_NAME MATCHES "FreeBSD|Fuchsia")
+    set(TEST_SUITE_CXX_ABI_LIBNAME "c++")
+  else()
----------------
Why c++ instead of c++abi?


================
Comment at: CMakeLists.txt:167
+  else()
+    set(TEST_SUITE_CXX_ABI_LIBNAME "stdc++")
+  endif()
----------------
Why stdc++ instead of supc++?


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58598/new/

https://reviews.llvm.org/D58598