[PATCH] D58391: [TailCallElim] Add tailcall elimination pass to LTO Pipelines

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 24 16:37:33 PST 2019


mehdi_amini added a comment.

In D58391#1408322 <https://reviews.llvm.org/D58391#1408322>, @tejohnson wrote:

> In D58391#1403188 <https://reviews.llvm.org/D58391#1403188>, @efriedma wrote:
>
> > What's the general state of the LTO pipeline at this point?  PassManagerBuilder::addLTOOptimizationPasses is adding passes in a really weird order (in particular, the placement of the inliner is really strange).  Has anyone looked at it recently?  Would it be worth killing it off in favor of the ThinLTO pipeline just so we don't have to maintain it?
>
>
> The reason they don't use the same pipeline is that it would be too expensive for regular LTO mode which is serial. ThinLTO can use a more aggressive post-link pipeline due to the parallelism. Mehdi did some measurements a couple years ago and found that using the ThinLTO pipeline for regular LTO increases the compile time in that mode significantly.


It doubled the link time of clang if I remember correctly.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58391/new/

https://reviews.llvm.org/D58391





More information about the llvm-commits mailing list