[PATCH] D58472: [WebAssembly] Remove unneeded MCSymbolRefExpr variants

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 22 14:28:41 PST 2019


sbc100 added a comment.

In D58472#1407531 <https://reviews.llvm.org/D58472#1407531>, @dschuff wrote:

> Makes sense. I think the thing that has changed compared to when we started is that symbol types like function, global, and event are more first-class in the wasm object format. Anyway, this change seems fine. I assume the asm parser already isn't using these annotations and we still round-trip?


Right, the symbols types from the special ".functype" and ".eventtype" declarations I believe, not from the references.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58472/new/

https://reviews.llvm.org/D58472





More information about the llvm-commits mailing list