[PATCH] D58486: [WebAssembly] Delete ThrowUnwindDest map from WasmEHFuncInfo

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 22 13:44:06 PST 2019


aheejin added a comment.

Kind of. I found it was not updated properly in LateEHPrepare so I created D58474 <https://reviews.llvm.org/D58474>, and abandoned it because it's better not to use `ThrowUnwindDestMap` anyway, because that kind of BB splitting can occur in other non-wasm passes as well, and now we can use successor info instead because there is at most one EH pad successor for a BB. (This was not the case for the first proposal.)
But we cannot remove `EHPadUnwindDest` because it is used here to set the new successor for newly added rethrow instruction. And this info is I think safe from transformation from other passes because both of them are EH pads, and all passes I have seen refrain from doing optimization on EH pads. But maybe there will be some passes that does that.. I can't be 100% sure.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58486/new/

https://reviews.llvm.org/D58486





More information about the llvm-commits mailing list