[PATCH] D49366: [LLD][COFF] Add support for /FUNCTIONPADMIN command-line option

[Alexandre Ganea via Phabricator via llvm-commits]

aganea marked 2 inline comments as done.
aganea added inline comments.


================
Comment at: COFF/Options.td:35
 def failifmismatch : P<"failifmismatch", "">;
+def functionpadmin : Joined<["/", "-", "-?"], "functionpadmin">, HelpText<"Prepares an image for hotpatching">;
 def guard   : P<"guard", "Control flow guard">;
----------------
ruiu wrote:
> ruiu wrote:
> > Newline before `HelpText` just like other definitions.
> You can use `P` just like above, can't you?
Yes, and that displays properly the help page, such as `/functionpadmin:<value>` instead of previous `/functionpadmin<value>`. Thank you for taking the time to review this!


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49366/new/

https://reviews.llvm.org/D49366