[PATCH] D49366: [LLD][COFF] Add support for /FUNCTIONPADMIN command-line option

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added inline comments.


================
Comment at: COFF/Driver.cpp:1387-1390
+  // Handle /functionpadmin
+  for (auto *Arg : Args.filtered(OPT_functionpadmin))
+    parseFunctionPadMin(Arg->getValue(), Config->Machine);
+
----------------
ruiu wrote:
> This place does not seem like a right place to add this code. We parse command line arguments much earlier.
We need `Config->Machine` to be set before parsing `/FUNCTIONPADMIN`. In some cases this is extracted from inputs, `run()` a few lines above.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49366/new/

https://reviews.llvm.org/D49366