[PATCH] D58406: Fix IR/Analysis layering issue in OptBisect

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

In D58406#1405975 <https://reviews.llvm.org/D58406#1405975>, @dblaikie wrote:

> I don't feel too strongly from the available options - but hope someone with a closer connection/appreciation for these classes might have an opinion about whether adding the extra virtual function to Pass is problematic (philosophically or practically) or not.


And here will I chime yet again with connection to NewPM (where, say, Passes do not have virtual functions).

... Looking at how this starts using Any wrapper I feel more and more motivated to create an IRUnit set of interfaces
that provide a generic handling for wrapping/unwrapping/description generation etc of IRUnits.
Doing it via virtual functions of Passes seems to be inelegant at best.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58406/new/

https://reviews.llvm.org/D58406